Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return to unpatched rules_scala #4065

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Return to unpatched rules_scala #4065

merged 1 commit into from
Jan 16, 2020
+2 −128

Conversation

stefanobaghino-da
Copy link
Contributor

The issue solved with a patch by

#4056

Has been solved upstream by

bazelbuild/rules_scala#920

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@stefanobaghino-da
Return to unpatched rules_scala
6691fbb 
The issue solved with a patch by

#4056

Has been solved upstream by

bazelbuild/rules_scala#920

CHANGELOG_BEGIN
CHANGELOG_END
cocreature
cocreature approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

aherrmann-da
aherrmann-da approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mergify mergify bot merged commit cd5ecab into master Jan 16, 2020
@mergify mergify bot deleted the go-back-to-unpatched-rules-scala branch January 16, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@aherrmann-da aherrmann-da aherrmann-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanobaghino-da @cocreature @aherrmann-da